[CRM-17718] Allow editing of campaign for recurring contributions AND
financial type for simple contributions Created: 16/Dec/15 Updated: 05/Jan/16 Resolved: 05/Jan/16
Status:
Project:
Component/s:
Affects
Version/s:
Fix Version/s:
Closed
CiviCRM
None
4.7
Type:
Reporter:
Resolution:
Labels:
Remaining
Estimate:
Time Spent:
Original
Estimate:
Bug
Eileen McNaughton
Fixed/Completed
PatchSubmitted
Not Specified
Attachments:
4.7
Priority:
Assignee:
Votes:
Minor
David Greenberg
0
Not Specified
Not Specified
Screen Shot 2015-12-21 at 4.37.22 PM.PNG
2015-12-21 at 4.43.42 PM.PNG
User and Admin Doc
Screen Shot
Documentation
Required?:
Contributed Code
Funding Source (see
https://civicrm.org/issuequeue):
Description
The contribution_recur table stores these 2 fields - but the edit recurring contribution page does
not currently allow them to be edited. The ticket is to add editability and to update the
repeattransaction api to. Editability will only be permitted if there is a single line item.
1) accept contribution_recur_id as a parameter
2) lookup the recurring contribution record for the campaign_id & financial_type_id (single line
item only) rather than the original contribution record.
3) campaign_id is currently accepted as a parameter - where provided this will continue to take
precedence.
The altered code is in the IPN code so is also accessed by paypal, authorize.net
Comments
Comment by Eileen McNaughton [ 16/Dec/15 ]
https://github.com/civicrm/civicrm-core/pull/7457
Comment by David Greenberg [ 22/Dec/15 ]
Eileen McNaughton I tested the changes to the Recurring Contribution edit form. Feedback:
1. The Financial Type field is NOT required which means that I can change a recurring
contribution from having a financial type to NOT having one. This does not seem correct to me
given that you want the recurring to act as a template for subsequent contributions.
2. Financial Type and Campaign should be added to the recurring contribution 'View' page now
- since they will be carried forward to subsequent contributions.
(screenshots attached)
Comment by Eileen McNaughton [ 23/Dec/15 ]
Thanks Dave - I have updated the PR to reflect your comments.
Note I also made 'installments' optional on the edit field since in other places 0 is
interchangeable with NULL for the contribution_recur table we should accept NULL. Making
people change it from NULL to 0 on the edit for is just odd.
Comment by Eileen McNaughton [ 27/Dec/15 ]
form fixes are in the PR now. It's not showing as clean on the tests but I think the issues are
unrelated
Generated at Tue Feb 09 19:36:48 UTC 2016 using JIRA 6.2#6252sha1:aa343257d4ce030d9cb8c531be520be9fac1c996.