Word - FreeSWITCH

advertisement

[FS-2451]

srtp lib fails to compile.

Created: 23/Jan/09 Updated: 24/Feb/14 Resolved: 27/Jan/09

Status:

Project:

Component/s:

Closed

FreeSWITCH freeswitch-core

None

Affects

Version/s:

Fix Version/s:

Security Level:

Type:

Reporter:

None public

Bug

Shane Burrell

Fixed

Priority:

Assignee:

Patch

Anthony Minessale II

0

Resolution:

Labels:

Remaining

Estimate:

None

1 day

Votes:

Time Spent:

Original

Estimate:

Not Specified

1 day

Environment:

CPU

Architecture:

Kernel: uname:

Userland:

Mac OSX x86-64, x86

OS X (Mach)

Darwin sbnet.local 9.6.0 Darwin Kernel Version 9.6.0: Mon Nov 24

17:37:00 PST 2008; root:xnu-1228.9.59~1/RELEASE_I386 i386 i386

OS X

OS X

Distribution:

Compiler:

Compiler

Version:

FreeSWITCH

GIT Revision:

gcc i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5490)

11474

GIT Master

Revision hash::

Description

Yes srtp fails to compile on current MacOS with latest XCode install. The following diff fixes the problem. // Comments are causing compile error

Index: crypto/cipher/aes_icm.c

===================================================================

--- crypto/cipher/aes_icm.c (revision 11474)

+++ crypto/cipher/aes_icm.c (working copy)

@@ -98,15 +98,8 @@

uint8_t *pointer;

int tmp;

- debug_print(mod_aes_icm,

- "allocating cipher with key length %d", key_len);

+ debug_print(mod_aes_icm, "allocating cipher with key length %d", key_len);

- // Ismacryp, for example, uses 16 byte key + 8 byte

- // salt so this function is called with key_len = 24.

- // The check for key_len = 30 does not apply. Our usage

- // of aes functions with key_len = values other than 30

- // has not broken anything. Don't know what would be the

- // effect of skipping this check for srtp in general.

if (!forIsmacryp && key_len != 30)

return err_status_bad_param;

@@ -300,7 +293,6 @@

if (forIsmacryp) {

uint32_t temp;

- //alex's clock counter forward

temp = ntohl(c->counter.v32[3]);

c->counter.v32[3] = htonl(++temp);

} else {

Comments

Comment by Brian West

[ 23/Jan/09 ]

I had the latest today.... I didn't see this issue i'll re-test.

/b

Comment by Brian West

[ 23/Jan/09 ]

Do you have any fink utils installed?

/b

Comment by Brian West

[ 23/Jan/09 ]

Fresh checkout.. bootstrap and configure do not fail on my imac... using latest dev tools also downloaded today same exact version. gcc version 4.0.1 (Apple Inc. build 5490)

/b

Comment by Shane Burrell

[ 23/Jan/09 ] cipher/aes_icm.c: In function 'aes_icm_alloc_ismacryp': cipher/aes_icm.c:104: error: syntax error before '/' token cipher/aes_icm.c:108: error: missing terminating ' character cipher/aes_icm.c: In function 'aes_icm_advance_ismacryp': cipher/aes_icm.c:303: error: syntax error before '/' token cipher/aes_icm.c:303: error: missing terminating ' character make: *** [cipher/aes_icm.o] Error 1

The actual error output.

Comment by Shane Burrell

[ 23/Jan/09 ]

SET

Apple_PubSub_Socket_Render=/tmp/launch-7kBB1q/Render

BASH=/bin/bash

BASH_ARGC=()

BASH_ARGV=()

BASH_LINENO=()

BASH_SOURCE=()

BASH_VERSINFO=([0]="3" [1]="2" [2]="17" [3]="1" [4]="release" [5]="i386-apple-darwin9.0")

BASH_VERSION='3.2.17(1)-release'

COLUMNS=130

COMMAND_MODE=legacy

DIRSTACK=()

DISPLAY=/tmp/launch-jhCcfu/:0

EUID=501

GROUPS=()

HISTFILE=/Users/shaneburrell/.bash_history

HISTFILESIZE=500

HISTSIZE=500

HOME=/Users/shaneburrell

HOSTNAME=sbnet.local

HOSTTYPE=i386

IFS=$' \t\n'

LANG=en_US.US-ASCII

LC_COLLATE=en_US.US-ASCII

LC_CTYPE=en_US.US-ASCII

LC_MESSAGES=en_US.US-ASCII

LC_MONETARY=en_US.US-ASCII

LC_NUMERIC=en_US.US-ASCII

LC_TIME=en_US.US-ASCII

LINES=43

LOGNAME=shaneburrell

MACHTYPE=i386-apple-darwin9.0

MAILCHECK=60

MANPATH=/usr/share/man:/usr/local/share/man:/usr/X11/man:/usr/local/git/man/

OLDPWD=/Users/shaneburrell/freeswitch/build

OPTERR=1

OPTIND=1

OSTYPE=darwin9.0

PATH=/opt/local/bin:/opt/local/sbin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11/bin:/opt/local/bin:/usr/local/git/bin:/usr/local/git/bin/

PIPESTATUS=([0]="0")

PPID=43299

PS1='\h:\W \u\$ '

PS2='> '

PS4='+ '

PWD=/Users/shaneburrell/freeswitch

SECURITYSESSIONID=8ae5a0

SHELL=/bin/bash

SHELLOPTS=braceexpand:emacs:hashall:histexpand:history:interactive-comments:monitor

SHLVL=1

SSH_AUTH_SOCK=/tmp/launch-tWqhBj/Listeners

TERM=linux

TERM_PROGRAM=iTerm.app

TMPDIR=/var/folders/gE/gEZ7wnLFFNGdlwM3hypaV++++TI/-Tmp-/

UID=501

USER=shaneburrell

_=ls

__CF_USER_TEXT_ENCODING=0x1F5:0:0

Comment by Brian West

[ 23/Jan/09 ]

Apple_PubSub_Socket_Render=/tmp/launch-2FGiT6/Render

BASH=/bin/bash

BASH_ARGC=()

BASH_ARGV=()

BASH_LINENO=()

BASH_SOURCE=()

BASH_VERSINFO=([0]="3" [1]="2" [2]="17" [3]="1" [4]="release" [5]="i386-apple-darwin9.0")

BASH_VERSION='3.2.17(1)-release'

COLUMNS=160

COMMAND_MODE=unix2003

DIRSTACK=()

DISPLAY=/tmp/launch-BiSLVK/:0

EUID=501

GROUPS=()

HISTFILE=/Users/brian/.bash_history

HISTFILESIZE=500

HISTSIZE=500

HOME=/Users/brian

HOSTNAME=air.local

HOSTTYPE=i386

IFS=$' \t\n'

LANG=en_US.UTF-8

LINES=61

LOGNAME=brian

MACHTYPE=i386-apple-darwin9.0

MAILCHECK=60

MANPATH=/usr/share/man:/usr/local/share/man:/usr/X11/man

OPTERR=1

OPTIND=1

OSTYPE=darwin9.0

PATH=/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11/bin

PIPESTATUS=([0]="0")

PPID=93105

PS1=$'\n\\[\E[01;31m\\]\\[email protected]\\h\\[\E[01;36m\\] [\\d \\@] \\[\E[01;33m\\] \\w\n\\[\E[00m\\]<\\#>:'

PS2='> '

PS4='+ '

PWD=/Users/brian

SECURITYSESSIONID=dac4f0

SHELL=/bin/bash

SHELLOPTS=braceexpand:emacs:hashall:histexpand:history:interactive-comments:monitor

SHLVL=1

SSH_AUTH_SOCK=/tmp/launch-9p2sWC/Listeners

TERM=xterm-color

TERM_PROGRAM=Apple_Terminal

TERM_PROGRAM_VERSION=240

TMPDIR=/var/folders/5b/5br7cLGhGB4+l2PgsffD3k+++TI/-Tmp-/

UID=501

USER=brian

_=/etc/bashrc

__CF_USER_TEXT_ENCODING=0x1F5:0:0

Comment by Brian West

[ 27/Jan/09 ]

I hand patched this in svn trunk.

/b

Generated at Tue Feb 09 16:15:37 EST 2016 using JIRA 6.4.10#64025sha1:5b8b74079161cd76a20ab66dda52747ee6701bd6.

Download