[EDS-48] Non-proportional logo scaling Created: 23/Aug/12
Status:
Project:
Component/s:
Affects
Version/s:
Fix Version/s:
Closed
Embedded Discovery Service
None
None
Type:
Reporter:
Resolution:
Labels:
Remaining
Estimate:
Time Spent:
Original
Estimate:
Bug
Peter Schober
Fixed
None
0 minutes
Attachments:
EDS_non-proportional_scaling.png
Linux
Operating
System:
CPU Type:
Web Server:
Updated: 14/Feb/15 Resolved: 09/Jan/15
1.1.0
Priority:
Assignee:
Major
Rod Widdowson
1 hour, 30 minutes
Not Specified
Multiple
Apache 2.2
Description
When integrating a logo from an institution into our metadata batch the EDS slightly
distorts/upsets this institution's image when displaying the previously selected IdP.
The image and mdui element in question is
<mdui:Logo height="121"
width="160">https://helpdesk.wu.ac.at/it/wu_logo_160.jpg</mdui:Logo>
A Shibboleth test SP (latest RPM available) using EDS (latest RPM available) showing the
described behaviour is available at https://saml-test.aco.net/
(To select the IdP in question type 'wu' into the search field.)
Comments
Comment by Peter Schober [ 05/Feb/13 ]
Any update on this? Did you at least get a chance to look at the example provided above and
confirm the issue? Since I only noticed that behaviour it may well be a problem with that image
alone. Or maybe I just need glasses
Comment by Rod Widdowson [ 05/Feb/13 ]
Sorry, this fell off the list. I'll put it back in the queue
Comment by Peter Schober [ 12/Aug/13 ]
I've found another Logo that has this issue and have now attached a showcase:
The left half of the image shows the Logo (from https://openidp.aco.net/we-are-open.png) as
shown in the EDS in Chromium 28 in X11 (GNU/Linux), Firefox does the same.
The right half of the image shows the logo scaled to 64 px height in Gimp.
This shows clearly the logo is almost exactly 3:2 in the original (right) and almost square when
shown in the EDS (left).
The image for this I got off the net, and converted it from JPEG/RGB to PNG/index colours in
Gimp.
Comment by Peter Schober [ 22/Nov/13 ]
Note that when adding another EDS instance to another service
https://eduroam.aco.net/discovery/ none of the scaling/distoring errors happen with those same
entities and logos. So it seems something at that service is off, possibly CSS related. I'll leave
this issue open for now, though.
Comment by Rod Widdowson [ 07/Jan/15 ]
As Peter says the EDS is realtively blamesless here - it is rendering the same thing in both cases.
It is pretty obvious to see that in the failing EDS the logo wants to be 69x64 and in the working
one it wants to be 69x49. So CSS is definitely in the loop.
Like many Shib developers CSS makes my mind melt. But I think that the differentiation may
come from bootstrp.min.css which on the failing DS has (according to Chrome) this Stanza
img
{ border:0;}
but on the working one has
img
{ width:auto; height:auto; border:0;max-width:100%;vertical-align:middle -ms-interopklatemode: bicubic;}
Whereas an out of the box DS has none of this. I have not been able to establish which bit of
CSS is provoking the change in size.
I suppose I could be persuaded to add the img
{height:auto;}
thing to out CSS, but see above about melting brain. I'd also want to see some wide testing of
deployments in case it broke something else.
Anybody have any thoughts?
Comment by Rod Widdowson [ 09/Jan/15 ]
I have checked in what I think is a fix for this as R120. However its CSS so I may have splayed
other stuff.
Is there any chance we can get a test on the failing EDS?
Comment by Rod Widdowson [ 09/Jan/15 ]
Not closing pending test
Comment by Rod Widdowson [ 14/Feb/15 ]
Closing issue. If it comes back after 1.1 I'll reinvestigate
Generated at Tue Feb 09 11:52:36 EST 2016 using JIRA 7.0.10#70120sha1:37e3d7a6fc4d580639533e7f7c232c925e554a6a.