[BATCH-1941] SimpleRetryPolicy javadoc is missing some important
informations Created: 04/Jan/13 Updated: 04/Jan/13
Status:
Project:
Component/s:
Affects
Version/s:
Fix Version/s:
Open
Spring Batch
Documentation
2.1.9
Type:
Reporter:
Resolution:
Labels:
Remaining
Estimate:
Time Spent:
Original
Estimate:
Improvement
Sebastien Lorber
Unresolved
None
Not Specified
None
Priority:
Assignee:
Votes:
Trivial
Unassigned
0
Not Specified
Not Specified
Description
My usecase was pretty simple:
I wanted a RetryPolicy that would retry all Exception class and subclasses, except a custom
exception NoRetryException - which is a RuntimeException - which would make the
RetryTemplate abord the retries.
After reading the Javadoc and code of some retry classes of the Retry/Batch framework, I found
out that I had to create my custom RetryPolicy.
Finally after loosing some time I noticed something: the use of a TreeSet and of
org.springframework.classify.SubclassClassifier.ClassComparator
This means that my usecase was handled by SimpleRetryPolicy, but the Javadoc doesn't
mention it. Perhaps for some people it seems to be the obvious behavior, but it was not for me.
The Javadoc doesn't mention this on class level javadoc of BinaryExceptionClassifier and
SubclassClassifier too.
"If the object to be classified is one of the keys of the provided
map, or is a subclass of one of the keys, then the map entry value for that
key is returned."
The only Javadoc reference to this feature is:
"Return the value from the type map whose key is the class of the given Throwable, or its
nearest ancestor if a subclass."
I think this should be better explained on the SimpleRetryPolicy
Generated at Tue Feb 09 11:55:39 UTC 2016 using JIRA 6.4.11#64026sha1:78f6ec473a3f058bd5d6c30e9319c7ab376bdb9c.