[#GLASSFISH-10436] flush jdbc connection pool is broken

advertisement
[GLASSFISH-10436] flush jdbc connection pool is broken Created: 20/Oct/09
Updated:
01/Dec/09 Resolved: 01/Dec/09
Status:
Project:
Component/s:
Affects
Version/s:
Fix Version/s:
Resolved
glassfish
jdbc
V3
Type:
Reporter:
Resolution:
Labels:
Remaining
Estimate:
Time Spent:
Original
Estimate:
Environment:
Bug
yifeng1
Fixed
None
Not Specified
Issuezilla Id:
10,436
V3
Priority:
Assignee:
Votes:
Major
Shalini
0
Not Specified
Not Specified
Operating System: SunOS
Platform: Sun
Description
promoted build : b68 glassfish-v3-b68.zip
browser: firefox 3
platform: open solaris
1. create a jdbc connection pool using derby database, during creation, don't
input any property name value set
2. obviously the pool created above will not make a connection to the database
due to missing connection properties
3. now under edit jdbc connection pool page, under advanced, click flush push button
4. gui reports flush successfully
flush should not succeed if the pool is not initiated.
Comments
Comment by Anissa Lam [ 20/Oct/09 ]
Backend is not reporting any error if db is not running. This is the same
behavior as in CLI.
Transferring to 'jdbc'. Maybe they can close this as duplicate of 9431.
Comment by Jagadish [ 20/Oct/09 ]
Probably, backend need to return the status of flush with a message
eg:
Pool not initialized
Flush successful
Flush failure
Transferring to Shalini
Comment by Shalini [ 03/Nov/09 ]
Flush status logs appropriate warning messages when the pool is not initialized
or the database is not started or any other exception. The status is either
success or failure. Flush connection pool command would fail in cases of pool
not initialized or database not running.
Sending
common/amx-ext-impl/src/main/java/org/glassfish/admin/amx/impl/ext/ConnectorRuntimeAPIProviderImpl.jav
Sending
connectors/connectors-internal-api/src/main/java/com/sun/appserv/connectors/internal/api/ConnectorRuntime.ja
Sending
connectors/connectors-runtime/src/main/java/com/sun/enterprise/connectors/ConnectorRuntime.java
Sending
connectors/connectors-runtime/src/main/java/com/sun/enterprise/connectors/service/ConnectorConnectionPoolA
Sending
connectors/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool/ConnectionPool.java
Sending
connectors/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool/PoolManager.java
Sending
connectors/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool/PoolManagerImpl.java
Sending
connectors/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool/ResourcePool.java
Sending
connectors/connectors-runtime/src/main/resources/com/sun/logging/enterprise/resource/resourceadapter/LogStri
Transmitting file data ..........
Committed revision 33779.
Comment by Shalini [ 09/Nov/09 ]

o

Issue 9431 has been marked as a duplicate of this issue. ***
Comment by yifeng1 [ 01/Dec/09 ]
verified the fix on promoted 74
an error message with partial stack trace will show if the pool is not
initiated. even though the error message can be more user friendly.
An error has occurred
com.sun.appserv.connectors.internal.api.ConnectorRuntimeException: "Flush
Connection Pool failed for DerbyPool. Please see server.log for more details."
com.sun.enterprise.connectors.service.ConnectorConnectionPoolAdminServiceImpl.flushConnectionPool(Conn
com.sun.enterprise.connectors.ConnectorRuntime.flushConnectionPool(ConnectorRuntime.java:1132)
org.glassfish.admin.amx.impl.ext.ConnectorRuntimeAPIProviderImpl.flushConnectionPool(ConnectorRuntimeA
Generated at Tue Feb 09 10:44:53 UTC 2016 using JIRA 6.2.3#6260sha1:63ef1d6dac3f4f4d7db4c1effd405ba38ccdc558.
Download